Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the order of arguments in spawned child proc #2913

Merged
merged 4 commits into from
Aug 9, 2017

Conversation

koistya
Copy link
Contributor

@koistya koistya commented Aug 7, 2017

Need to be able to pass Node args into the spawned Node process:

$ npx react-scripts --inspect build

@Timer
Copy link
Contributor

Timer commented Aug 7, 2017

Hmm, what about putting the args after build (both cases)?

@koistya
Copy link
Contributor Author

koistya commented Aug 7, 2017

@Timer it would add some "magic", how you would decide which arguments need to be passed to Node.js process and which to the automation script? In my understanding, it wouldn't only make it difficult to implement, but also it won't be intuitively clear how it works.

@Timer
Copy link
Contributor

Timer commented Aug 7, 2017

Ah, good point @koistya I didn't think of that. Thanks for the clarification, I was still waking up!

@Timer
Copy link
Contributor

Timer commented Aug 7, 2017

I'd say this supersedes #2839 and resolves #2820.

Thanks!

@Timer Timer added this to the 1.0.11 milestone Aug 7, 2017
Copy link
Contributor

@Timer Timer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll leave this unmerged until we're about to cut the next release in case anyone has feedback.

@dfbaskin
Copy link
Contributor

dfbaskin commented Aug 8, 2017

Nice! Yes, I agree, this should supersede #2839 and resolve #2820.

@Timer
Copy link
Contributor

Timer commented Aug 9, 2017

Hi there! This change is out in react-scripts@1.0.11; please give it a go! Thanks.

@koistya koistya deleted the patch-1 branch August 9, 2017 06:51
JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Aug 9, 2017
* Fix the order of arguments in spawned child proc

* Update react-scripts.js

* Remove a comma

* Update react-scripts.js
chrisportela pushed a commit to peopleticker/create-react-app that referenced this pull request Aug 10, 2017
zangrafx added a commit to absolvent/create-react-app that referenced this pull request Aug 13, 2017
* commit 'bfaee410c502a95076a6bd89721c76ca08e15f7b': (39 commits)
  Publish
  Prepare for 1.0.11 release (facebook#2924)
  Update dev deps (facebook#2923)
  Update README.md
  Use env variable to disable source maps (facebook#2818)
  Make formatWebpackMessages return all messages (facebook#2834)
  Adjust the `checkIfOnline` check if in a corporate proxy environment (facebook#2884)
  Fix the order of arguments in spawned child proc (facebook#2913)
  Feature/webpack 3 4 (facebook#2875)
  Allow importing package.json (facebook#2468)
  Re-enable flowtype warning (facebook#2718)
  Format UglifyJs error (facebook#2650)
  Unstage yarn.lock pre-commit (facebook#2700)
  Update README.md
  Update README.md
  Add Electrode to alternatives (facebook#2728)
  Fix parsing HTML/JSX tags to real elements (facebook#2796)
  Update webpack version note (facebook#2798)
  Use modern syntax feature (facebook#2873)
  Allow use of scoped packages with a pinned version (facebook#2853)
  ...

# Conflicts:
#	packages/react-scripts/config/webpack.config.dev.js
#	packages/react-scripts/config/webpack.config.prod.js
#	packages/react-scripts/package.json
chrisportela pushed a commit to 0xaio/create-react-app that referenced this pull request Aug 29, 2017
JohnNilsson referenced this pull request in JohnNilsson/create-react-app-typescript Sep 9, 2017
* Fix the order of arguments in spawned child proc

* Update react-scripts.js

* Remove a comma

* Update react-scripts.js
kasperpeulen pushed a commit to kasperpeulen/create-react-app that referenced this pull request Sep 24, 2017
* Fix the order of arguments in spawned child proc

* Update react-scripts.js

* Remove a comma

* Update react-scripts.js
swengorschewski referenced this pull request in swengorschewski/cra-typescript-electron Oct 16, 2017
* Fix the order of arguments in spawned child proc

* Update react-scripts.js

* Remove a comma

* Update react-scripts.js
@lock lock bot locked and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants